Skip to content

F
Front-End
Unverified Commit 0105c8f3 authored by Kate Lovett's avatar Kate Lovett Committed by GitHub
Browse files
Options

Dart Fix for InputDecoration (#78672)

parent c2d12ea4
Hide whitespace changes
Inline Side-by-side
Showing with 233 additions and 0 deletions
packages/flutter/lib/fix_data.yaml
View file @ 0105c8f3
......@@ -12,6 +12,211 @@
version: 1
transforms:
# Changes made in https://github.com/flutter/flutter/pull/46115
- title: "Migrate to 'floatingLabelBehavior'"
date: 2020-01-15
element:
uris: [ 'material.dart' ]
field: 'hasFloatingPlaceholder'
inClass: 'InputDecorationTheme'
changes:
- kind: 'rename'
newName: 'floatingLabelBehavior'
# Changes made in https://github.com/flutter/flutter/pull/46115
- title: "Migrate to 'floatingLabelBehavior'"
date: 2020-01-15
element:
uris: [ 'material.dart' ]
constructor: ''
inClass: 'InputDecorationTheme'
oneOf:
- if: "hasFloatingPlaceholder == 'true'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% FloatingLabelBehavior %}.auto'
requiredIf: "hasFloatingPlaceholder == 'true'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder == 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder == 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% hasFloatingPlaceholder %} ? {% FloatingLabelBehavior %}.auto : {% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
variables:
hasFloatingPlaceholder:
kind: 'fragment'
value: 'arguments[hasFloatingPlaceholder]'
# Changes made in https://github.com/flutter/flutter/pull/46115
- title: "Migrate to 'floatingLabelBehavior'"
date: 2020-01-15
element:
uris: [ 'material.dart' ]
field: 'hasFloatingPlaceholder'
inClass: 'InputDecoration'
changes:
- kind: 'rename'
newName: 'floatingLabelBehavior'
# Changes made in https://github.com/flutter/flutter/pull/46115
- title: "Rename to 'floatingLabelBehavior'"
date: 2020-01-15
element:
uris: [ 'material.dart' ]
constructor: 'collapsed'
inClass: 'InputDecoration'
oneOf:
- if: "hasFloatingPlaceholder == 'true'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% FloatingLabelBehavior %}.auto'
requiredIf: "hasFloatingPlaceholder == 'true'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder == 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder == 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% hasFloatingPlaceholder %} ? {% FloatingLabelBehavior %}.auto : {% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
variables:
hasFloatingPlaceholder:
kind: 'fragment'
value: 'arguments[hasFloatingPlaceholder]'
# Changes made in https://github.com/flutter/flutter/pull/46115
- title: "Rename to 'floatingLabelBehavior'"
date: 2020-01-15
element:
uris: [ 'material.dart' ]
constructor: ''
inClass: 'InputDecoration'
oneOf:
- if: "hasFloatingPlaceholder == 'true'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% FloatingLabelBehavior %}.auto'
requiredIf: "hasFloatingPlaceholder == 'true'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder == 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder == 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
- if: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
changes:
- kind: 'addParameter'
index: 14
name: 'floatingLabelBehavior'
style: optional_named
argumentValue:
expression: '{% hasFloatingPlaceholder %} ? {% FloatingLabelBehavior %}.auto : {% FloatingLabelBehavior %}.never'
requiredIf: "hasFloatingPlaceholder != 'true' && hasFloatingPlaceholder != 'false'"
variables:
FloatingLabelBehavior:
kind: 'import'
uris: [ 'material.dart' ]
name: 'FloatingLabelBehavior'
- kind: 'removeParameter'
name: 'hasFloatingPlaceholder'
variables:
hasFloatingPlaceholder:
kind: 'fragment'
value: 'arguments[hasFloatingPlaceholder]'
# Changes made in https://github.com/flutter/flutter/pull/59127
- title: "Migrate to 'label'"
date: 2020-07-09
......
packages/flutter/test_fixes/material.dart
View file @ 0105c8f3
......@@ -178,4 +178,19 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/59127
const BottomNavigationBarItem bottomNavigationBarItem = BottomNavigationBarItem(title: myTitle);
bottomNavigationBarItem.title;
// Changes made in https://github.com/flutter/flutter/pull/46115
const InputDecoration inputDecoration = InputDecoration(hasFloatingPlaceholder: true);
InputDecoration(hasFloatingPlaceholder: false);
InputDecoration();
InputDecoration.collapsed(hasFloatingPlaceholder: true);
InputDecoration.collapsed(hasFloatingPlaceholder: false);
InputDecoration.collapsed();
inputDecoration.hasFloatingPlaceholder;
const InputDecorationTheme inputDecorationTheme = InputDecorationTheme(hasFloatingPlaceholder: true);
InputDecorationTheme(hasFloatingPlaceholder: false);
InputDecorationTheme();
inputDecorationTheme.hasFloatingPlaceholder;
}
packages/flutter/test_fixes/material.dart.expect
View file @ 0105c8f3
......@@ -178,4 +178,17 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/59127
const BottomNavigationBarItem bottomNavigationBarItem = BottomNavigationBarItem(label: myTitle);
bottomNavigationBarItem.label;
// Changes made in https://github.com/flutter/flutter/pull/46115
const InputDecoration inputDecoration = InputDecoration(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecoration(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecoration();
InputDecoration.collapsed(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecoration.collapsed(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecoration.collapsed();
inputDecoration.floatingLabelBehavior;
const InputDecorationTheme inputDecorationTheme = InputDecorationTheme(floatingLabelBehavior: FloatingLabelBehavior.auto);
InputDecorationTheme(floatingLabelBehavior: FloatingLabelBehavior.never);
InputDecorationTheme();
inputDecorationTheme.floatingLabelBehavior;
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab